lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 26 Jun 2007 09:13:57 -0500
From:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To:	Girish Shilamkar <girish@...syssoft.com>
Cc:	Ext4 Mailing List <linux-ext4@...r.kernel.org>,
	Andreas Dilger <adilger@...sterfs.com>,
	Theodore Tso <tytso@....edu>, Mingming Cao <cmm@...ibm.com>
Subject: Re: [PATCH] Journal Checksum - rebased to 2.6.22-rc5

On Tue, 2007-06-26 at 16:17 +0530, Girish Shilamkar wrote:
> On Fri, 2007-06-22 at 15:06 +0530, Girish Shilamkar wrote:
> > Hi,
> > 	The previous patch was an old one. Hence I am sending the latest patch
> > rebased to 2.6.22-rc5. I have also fixed few coding style issues in both
> > the patches.
> > 
> > Regards,
> > Girish
> This patch had a bug. Thanks to Valerie for pointing it out.

I updated the patch queue with the updated patch and this fix.

Thanks,
Shaggy

> Regards,
> Girish.
> 
> Index: linux-2.6.22-rc5/fs/jbd2/commit.c
> ===================================================================
> --- linux-2.6.22-rc5.orig/fs/jbd2/commit.c
> +++ linux-2.6.22-rc5/fs/jbd2/commit.c
> @@ -121,8 +121,8 @@ static int journal_submit_commit_record(
>         bh = jh2bh(descriptor);
> 
>         for (i = 0; i < bh->b_size; i += 512) {
> -               struct commit_header *tmp = (struct commit_header *)bh->b_data +
> -                                           i;
> +               struct commit_header *tmp = (struct commit_header *)(bh->b_data+
> +                                           i);
>                 tmp->h_magic = cpu_to_be32(JBD2_MAGIC_NUMBER);
>                 tmp->h_blocktype = cpu_to_be32(JBD2_COMMIT_BLOCK);
>                 tmp->h_sequence = cpu_to_be32(commit_transaction->t_tid);
> 
> 

-- 
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists