linux-ext4 - Re: [PATCH] Faster ext2_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070709180148.GA5747@martell.zuzino.mipt.ru>
Date:	Mon, 9 Jul 2007 22:01:48 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Jörn Engel <joern@...fs.org>
Cc:	akpm@...l.org, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] Faster ext2_clear_inode()

On Mon, Jul 09, 2007 at 10:34:32AM +0200, Jörn Engel wrote:
> On Mon, 9 July 2007 08:11:22 +0400, Alexey Dobriyan wrote:
> > 
> > If CONFIG_EXT2_FS_POSIX_ACL is not configured, ext2_clear_inode() will be empty
> > function. However, there still will be call and immediate return which can be
> > avoided.
> > [...]
> > +#ifdef CONFIG_EXT2_FS_POSIX_ACL
> >  static void ext2_clear_inode(struct inode *inode)
> >  {
> > -#ifdef CONFIG_EXT2_FS_POSIX_ACL
> >  	struct ext2_inode_info *ei = EXT2_I(inode);
> >  
> >  	if (ei->i_acl && ei->i_acl != EXT2_ACL_NOT_CACHED) {
> > @@ -197,8 +197,10 @@ static void ext2_clear_inode(struct inode *inode)
> >  		posix_acl_release(ei->i_default_acl);
> >  		ei->i_default_acl = EXT2_ACL_NOT_CACHED;
> >  	}
> > -#endif
> >  }
> > +#else
> > +#define ext2_clear_inode NULL
> > +#endif
> 
> Are you sure your patch makes a difference?  Does the resulting binary
> change at all?

Yes. Note that ext2_clear_inode() is referenced from ext2_sops, so even
empty, it leaves traces in resulting kernel.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html