linux-ext4 - Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070710214221.26539eb6.akpm@linux-foundation.org>
Date:	Tue, 10 Jul 2007 21:42:21 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Cédric Augonnet" 
	<cedric.augonnet@...il.com>
Cc:	cmm@...ibm.com, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [EXT4 set 6][PATCH 1/1]Export jbd stats through procfs

On Tue, 10 Jul 2007 23:21:49 -0400 "Cédric Augonnet" <cedric.augonnet@...il.com> wrote:

> 2007/7/10, Andrew Morton <akpm@...ux-foundation.org>:
> 
> Hi all,
> 
> > > +     size = sizeof(struct transaction_stats_s);
> > > +     s->stats = kmalloc(size, GFP_KERNEL);
> > > +     if (s == NULL) {
> > > +             kfree(s);
> > > +             return -EIO;
> >
> > ENOMEM
> 
> I'm sorry if i missed some point, but i just don't see the use of such
> a kfree here, not sure Andrew meant you should only return ENOMEM
> instead, but why issuing those kfree(NULL), instead of just a if (!s)
> return ENOMEM ?
> 

You found a bug.  It was meant to be

	if (s->stats == NULL)


-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html