lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Jul 2007 12:22:57 +0100 From: Andy Whitcroft <apw@...dowen.org> To: Andrew Morton <akpm@...ux-foundation.org> CC: cmm@...ibm.com, linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org Subject: Re: [EXT4 set 5][PATCH 1/1] expand inode i_extra_isize to support features in larger inode The next version of checkpatch.pl (0.08) should have support for a number of the missed sylistics you mention. Will let them soak for a bit to ensure we're not majorly regressing anything else. -apw ERROR: braces {} are not necessary for single statements #4: FILE: Z11.c:1: +if (EXT4_I(inode)->i_extra_isize >= new_extra_isize) { WARNING: declaring multiple variables together should be avoided #9: FILE: Z11.c:6: +unsigned int total_size, shift_bytes, temp = ~0U; WARNING: multiple assignments should be avoided #12: FILE: Z11.c:9: +is->s.not_found = bs->s.not_found = -ENODATA; WARNING: kfree(NULL) is safe this check is probabally not required #16: FILE: Z11.c:13: +if (bs) + kfree(bs); - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists