linux-ext4 - Re: Random corruption test for e2fsck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070712051557.GC5586@schatzie.adilger.int>
Date:	Wed, 11 Jul 2007 23:15:57 -0600
From:	Andreas Dilger <adilger@...sterfs.com>
To:	Theodore Tso <tytso@....edu>
Cc:	Kalpak Shah <kalpak@...sterfs.com>,
	linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: Random corruption test for e2fsck

On Jul 11, 2007  13:43 -0400, Theodore Tso wrote:
>     Fix e2fsck segfault on very badly damaged filesystems
>     
> --- a/e2fsck/dirinfo.c
> +++ b/e2fsck/dirinfo.c
> @@ -126,7 +126,7 @@ void e2fsck_add_dir_info(e2fsck_t ctx, ext2_ino_t ino, ext2_ino_t parent)
>  		ctx->dir_info->size += 10;
>  		retval = ext2fs_resize_mem(old_size, ctx->dir_info->size *
>  					   sizeof(struct dir_info),
> -					   &ctx->dir_info);
> +					   &ctx->dir_info->array);
>  		if (retval) {
>  			ctx->dir_info->size -= 10;
>  			return;

This appears to fix the problem.  I was previously able to crash e2fsck
within a couple of runs, now it is running in a loop w/o problems.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html