[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <46A12E22.3030102@redhat.com>
Date: Fri, 20 Jul 2007 16:50:26 -0500
From: Eric Sandeen <sandeen@...hat.com>
To: ext4 development <linux-ext4@...r.kernel.org>
Subject: [PATCH e2fsprogs] fix test in ext2fs_check_desc() for inode table
within block group
The test in ext2fs_check_desc() is off by one; if the inode table
goes all the way to the last block of the block group, it will
falsely assert that it has extended past it. The last block
of a range is start + len -1, not start + len.
Testcase to follow.
Signed-off-by: Eric Sandeen <sandeen@...hat.com>
Index: e2fsprogs-1.40.2/lib/ext2fs/check_desc.c
===================================================================
--- e2fsprogs-1.40.2.orig/lib/ext2fs/check_desc.c
+++ e2fsprogs-1.40.2/lib/ext2fs/check_desc.c
@@ -61,7 +61,7 @@ errcode_t ext2fs_check_desc(ext2_filsys
*/
if (fs->group_desc[i].bg_inode_table < first_block ||
((fs->group_desc[i].bg_inode_table +
- fs->inode_blocks_per_group) > last_block))
+ fs->inode_blocks_per_group - 1) > last_block))
return EXT2_ET_GDESC_BAD_INODE_TABLE;
}
return 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists