linux-ext4 - Re: [RFC] basic delayed allocation in ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46A88A96.7@clusterfs.com>
Date:	Thu, 26 Jul 2007 15:50:46 +0400
From:	Alex Tomas <alex@...sterfs.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
CC:	ext4 development <linux-ext4@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [RFC] basic delayed allocation in ext4

Aneesh Kumar K.V wrote:
>> +    /* first, we need to know whether the block is allocated already
>> +     * XXX: when the filesystem has a lot of free blocks, we could
>> +     * reserve even allocated blocks to save this lookup */
>> +    ret = ext4_get_blocks_wrap(NULL, inode, iblock, 1,  bh_result, 0, 
>> 0);
>> +    if (ret >= 0) {
> 
> 
> I guess this should be (ret > 0)

well, no. it has to catch allocated and non-allocated blocks
(though can be written more clear, probably)

> I was not able to find mpage_da_writepages()..

sorry, it's part of vfs delayed allocation patch, should be on the list now.

thanks, Alex


-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html