linux-ext4 - Re: [PATCH][e2fsprogs] Move ext2fs_struct_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070809214254.GB5438@thunk.org>
Date:	Thu, 9 Aug 2007 17:42:54 -0400
From:	Theodore Tso <tytso@....edu>
To:	"Jose R. Santos" <jrs@...ibm.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH][e2fsprogs] Move ext2fs_struct_generic_bitmap back into ext2fs.h

On Tue, Aug 07, 2007 at 04:16:39PM -0500, Jose R. Santos wrote:
> From: Jose R. Santos <jrs@...ibm.com>
> 
> Move ext2fs_struct_generic_bitmap back into ext2fs.h
> 
> In Commit: f1f115a78f5ea599fc5f8815a741d43fedd5840d
> 
> The ext2fs_struct_generic_bitmap structure is remove from ext2fs.h and
> put into gen_bitmap.c.  This breaks big endian compiles since swapfs.c
> uses this structure as well if EXT2_BIG_ENDIAN_BITMAPS is defined.

Actually, it's rw_bitmaps.c, and I don't want to do this because this
is part of the cleanups where I am trying to localize code that knows
about the in-memory encoding of bitmaps.

It turns out the need for this was only in the very first ports of
Linux to the Powerpc, and there haven't been kernels that would mount
big-endian superblocks since, oh, 1998 or so (in the 2.0 days).

So probably the better fix is one where we don't allow big-endian
filesystems any more.  On all modern systems, we use little-endian
encoding of the superblock, and the bitmaps don't need byte-swapping.

							- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html