linux-ext4 - Re: [PATCH] dir_index: error out instead of BUG on corrupt hash dir limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070810082622.GK6689@schatzie.adilger.int>
Date:	Fri, 10 Aug 2007 02:26:22 -0600
From:	Andreas Dilger <adilger@...sterfs.com>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] dir_index: error out instead of BUG on corrupt hash dir limit

On Aug 09, 2007  16:33 -0500, Eric Sandeen wrote:
> A corrupt ondisk hash dir limit will trip an assert in dx_probe,
> which calls BUG().  Instead, we can just issue the warning and
> fail dx_probe like the other 3 tests just before it.  Thanks
> to aviro for suggesting this...  Tested with a hand-crafted
> corrupt ext3 image, issues:
> 
> EXT3-fs warning (device loop0): dx_probe: Corrupt limit in dir inode 14337
> 
> vs. previous:
> 
> Assertion failure in dx_probe() at fs/ext3/namei.c:383: "dx_get_limit(entries) == dx_root_limit(dir, root->info.info_length)"
> ------------[ cut here ]------------
> kernel BUG at fs/ext3/namei.c:383!

This has my blessing, you can add:

Acked-by: Andreas Dilger <adilger@...sterfs.com>

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html