[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46D3B1AE.40408@redhat.com>
Date: Tue, 28 Aug 2007 00:25:02 -0500
From: Eric Sandeen <sandeen@...hat.com>
To: ext4 development <linux-ext4@...r.kernel.org>
Subject: [PATCH V2] fix mballoc oopses on mkdir
Ugh. brain clearly not fully engaged... here we go:
------------------
Tried out Ted's git tree + all pending patches today, and
immediately oopsed on a mkdir thanks to this in
ext4_mb_new_group_pa()
BUG_ON(!S_ISREG(ac->ac_inode->i_mode));
(there are 54 BUGs and BUG_ONs in this file...!)
I think something like this patch is needed?
Signed-off-by: Eric Sandeen <sandeen@...hat.com>
Index: ext4.git/fs/ext4/extents.c
===================================================================
--- ext4.git.orig/fs/ext4/extents.c
+++ ext4.git/fs/ext4/extents.c
@@ -2535,7 +2535,10 @@ int ext4_ext_get_blocks(handle_t *handle
ar.goal = ext4_ext_find_goal(inode, path, iblock);
ar.logical = iblock;
ar.len = allocated;
- ar.flags = EXT4_MB_HINT_DATA;
+ if (S_ISREG(inode->i_mode))
+ ar.flags = EXT4_MB_HINT_DATA;
+ else
+ ar.flags = 0;
newblock = ext4_mb_new_blocks(handle, &ar, &err);
if (!newblock)
goto out2;
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists