linux-ext4 - Re: [PATCH V2] fix mballoc oopses on mkdir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Aug 2007 15:29:06 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Andreas Dilger <adilger@...sterfs.com>
CC:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH V2] fix mballoc oopses on mkdir

Andreas Dilger wrote:

>> (there are 54 BUGs and BUG_ONs in this file...!)
> 
> Yes, we like lots of assertions in our code, because it is exceedingly
> complex to debug otherwise.

But wouldn't error recovery be a better choice?  You could macro-ize it
to BUG for development purposes if you wanted, I suppose...

(xfs has a mask that can be set to turn various flavors of errors into
BUGs, that has been useful at times to catch the system state at the
point of the error)

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html