linux-ext4 - Re: [PATCH V2] fix mballoc oopses on mkdir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070830143147.GX5377@schatzie.adilger.int>
Date:	Thu, 30 Aug 2007 08:31:47 -0600
From:	Andreas Dilger <adilger@...sterfs.com>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH V2] fix mballoc oopses on mkdir

On Aug 28, 2007  15:29 -0500, Eric Sandeen wrote:
> Andreas Dilger wrote:
> >> (there are 54 BUGs and BUG_ONs in this file...!)
> > 
> > Yes, we like lots of assertions in our code, because it is exceedingly
> > complex to debug otherwise.
> 
> But wouldn't error recovery be a better choice?  You could macro-ize it
> to BUG for development purposes if you wanted, I suppose...

No, the goal is if something "impossible" happens you want to stop dead
at that point instead of continuing to work in an unknown environment.
I believe that all of the extents/mballoc code will NOT BUG on bad data
from disk.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html