linux-ext4 - Re: [PATCH] placate checkpatch.pl to some degree for mballoc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46D8BC9B.8060005@redhat.com>
Date:	Fri, 31 Aug 2007 20:12:59 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Andreas Dilger <adilger@...sterfs.com>
CC:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] placate checkpatch.pl to some degree for mballoc.c

Andreas Dilger wrote:
> On Aug 31, 2007  16:28 -0500, Eric Sandeen wrote:
>> Here's a patch for mballoc.c, to make checkpatch happier with it.
>>
>> I was about as pedantic as I could be, except for a few things it 
>> complained about which I just could not agree with. :)
> 
> I'm happy with the changes, since I've adopted the kernel CodingStyle
> as my own, but not everyone at CFS has.
> 

...

>>
>> -Eric
>>
>> Make checkpatch happier with mballoc.c
>>
>> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> 
> You can add my "Signed-off-by: Andreas Dilger <adilger@...sterfs.com>"
> 
>> @@ -829,7 +845,8 @@ ext4_mb_mark_free_simple(struct super_bl
>> -			mb_clear_bit(first >> min, buddy + sbi->s_mb_offsets[min]);
>> +			mb_clear_bit(first >> min,
>> +					buddy + sbi->s_mb_offsets[min]);
> 
> Hmm, shouldn't "buddy" be aligned on the '(' from the previous line?

...

Yup, I did this a little bit fast & furious; I'll fix those up.

Thanks,

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html