linux-ext4 - Re: [RFC] mballoc patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46E55632.6040804@redhat.com>
Date:	Mon, 10 Sep 2007 09:35:30 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Alex Tomas <alex@...sterfs.com>
CC:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	linux-ext4@...r.kernel.org
Subject: Re: [RFC] mballoc patches

Alex Tomas wrote:
> Eric Sandeen wrote:
>> +/*
>> + * default stripe size = 1MB
>> + */
>> +#define MB_DEFAULT_STRIPE              256
> 
> agree, though seems we'd better make it blocksize-insensitive

Well, for now this isn't even used at *all* so might as well just remove it.

>> +static int mb_find_extent(struct ext4_buddy *e3b, int order, int block,
>> +                               int needed, struct ext4_free_extent *ex)
>>
>> how many "what" are needed?
> 
> well, blocks :)

I figured, though bytes is a possibility.  :)  In general, being
explicit about units helps; xfs suffers a bit from byte/block/sector
confusion in the code, in some places.

>> Also there are a *lot* of BUGs and BUG_ONs added in this patch... are
>> none of these recoverable?
> 
> well, I'll review the code in this regard again, but most of them are not.
> not that I like kernel panics, but BUG_ON() are very helpful to maintain
> code, especially in long-term.

Ok, I just think there might be upstream pushback on these, at one point
at least they were trying to reduce the nr. of BUG calls in the code...

Thanks,
-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html