linux-ext4 - Re: [PATCH] FLEX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070911232139.GY5377@schatzie.adilger.int>
Date:	Tue, 11 Sep 2007 17:21:39 -0600
From:	Andreas Dilger <adilger@...sterfs.com>
To:	"Jose R. Santos" <jrs@...ibm.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] FLEX_BG Kernel support.

On Sep 11, 2007  07:27 -0500, Jose R. Santos wrote:
> On Tue, 11 Sep 2007 00:04:43 -0600
> "Andreas Dilger" <adilger@...sterfs.com> wrote:
> > On 9/10/07, Jose R. Santos <jrs@...ibm.com> wrote:
> > > @@ -1254,7 +1254,8 @@ static int ext4_check_descriptors (struct super_block * sb)
> > >
> > >         for (i = 0; i < sbi->s_groups_count; i++)
> > >         {
> > > -               if (i == sbi->s_groups_count - 1)
> > > +               if (i == sbi->s_groups_count - 1 || EXT4_HAS_INCOMPAT_FEATURE(sb,
> > > +                                       EXT4_FEATURE_INCOMPAT_FLEX_BG))
> > >                         last_block = ext4_blocks_count(sbi->s_es) - 1;
> > 
> > No need to check this featyre for every  group, once at the beginning
> > of the function is enough.
> > 
> 
> Do you mean something like the original patch?
> http://lists.openwall.net/linux-ext4/2007/07/12/20
> 
> Wouldn't we need to check all the descriptor for corruption if checksum
> is not enable on the filesystem?

Yes, I just meant you don't need to have:

	EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_FLEX_BG))

for each time through the loop.  That loop is walked 8000 times per TB
at mount, so if we can make it faster we should do so.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html