linux-ext4 - Re: Sparse endian issues with patches.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070913003258.GR5377@schatzie.adilger.int>
Date:	Wed, 12 Sep 2007 18:32:58 -0600
From:	Andreas Dilger <adilger@...sterfs.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	valerie.clement@...l.net, Mingming Cao <cmm@...ibm.com>,
	linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: Sparse endian issues with patches.

On Sep 12, 2007  22:18 +0530, Aneesh Kumar K.V wrote:
> Attaching below patch that fix the sparse warning for ext4.

It would be good to also fix the "raw" access of split 48-bit and 64-bit
fields as I previously sent to the list.  A new typedef for these fields
(on disk) would ensure that they are not accessed directly and give
compiler warnings if new patches don't have the right macro usage.

> -				if (mnt_count != sbi->s_es->s_mnt_count) {
> +				if (mnt_count != le16_to_cpu(sbi->s_es->s_mnt_count)) {

That overflows 80 columns, as do several other lines.
> 

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html