linux-ext4 - Re: [PATCH] Ext4: Uninitialized Block Groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46F10FA4.6060902@bull.net>
Date:	Wed, 19 Sep 2007 14:01:40 +0200
From:	Valerie Clement <valerie.clement@...l.net>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	Avantika Mathur <mathur@...ux.vnet.ibm.com>,
	linux-ext4@...r.kernel.org, Andreas Dilger <adilger@...sterfs.com>,
	cmm@...ibm.com
Subject: Re: [PATCH] Ext4: Uninitialized Block Groups

Aneesh Kumar K.V wrote:
> the variable free is confusingly named here. It is not the free inode 
> count.
> rather it indicate the last used relative inode number in the group. How 
> about
> the below ?
> 
> -aneesh

I agree, it's better.
   Valérie

> 
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index 4250c02..cfe2e09 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -633,17 +633,21 @@ got:
>     /* If we didn't allocate from within the initialized part of the inode
>      * table then we need to initialize up to this inode. */
>     if (EXT4_HAS_RO_COMPAT_FEATURE(sb, EXT4_FEATURE_RO_COMPAT_GDT_CSUM)) {
> -        if (gdp->bg_flags & cpu_to_le16(EXT4_BG_INODE_UNINIT)) {
> +        if (gdp->bg_flags & cpu_to_le16(EXT4_BG_INODE_UNINIT))
>             gdp->bg_flags &= cpu_to_le16(~EXT4_BG_INODE_UNINIT);
> -            free = EXT4_INODES_PER_GROUP(sb);
> -        } else {
> -            free = EXT4_INODES_PER_GROUP(sb) -
> -                le16_to_cpu(gdp->bg_itable_unused);
> -        }
> 
> -        if (ino > free)
> +        /*
> +         * Check the relative inode number against the last used
> +         * relative inode number in this group. if it is greater
> +         * we need to  update the bg_itable_unused count
> +         *
> +         */
> +        if (ino > (EXT4_INODES_PER_GROUP(sb) -
> +                    le16_to_cpu(gdp->bg_itable_unused))) {
> +
>             gdp->bg_itable_unused =
>                 cpu_to_le16(EXT4_INODES_PER_GROUP(sb) - ino);
> +        }
>     }
> 
>     gdp->bg_free_inodes_count =
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html