lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Sep 2007 14:26:31 -0500 From: Dave Kleikamp <shaggy@...ux.vnet.ibm.com> To: cmm@...ibm.com Cc: Andrew Morton <akpm@...ux-foundation.org>, Christoph Hellwig <hch@...radead.org>, Badari Pulavarty <pbadari@...ibm.com>, Christoph Lameter <clameter@....com>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, ext4 development <linux-ext4@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] JBD slab cleanups On Wed, 2007-09-19 at 12:15 -0700, Mingming Cao wrote: > Here is the patch to clean up __GFP_NOFAIL flag in jbd/jbd2. In all > cases except one handles memory allocation failure so I get rid of those > GFP_NOFAIL flags. > > Also, shouldn't we use GFP_KERNEL instead of GFP_NOFS flag for kmalloc > in jbd/jbd2? I will send a separate patch to cleanup that. No. GFP_NOFS avoids deadlock. It prevents the allocation from making recursive calls back into the file system that could end up blocking on jbd code. Shaggy -- David Kleikamp IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists