linux-ext4 - The jbd_GFP_NORFAIL patch caused the jbd_kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <E1IZohl-0002K5-CT@tinytim.thunk.org>
Date:	Mon, 24 Sep 2007 10:14:33 -0400
From:	"Theodore Ts'o" <tytso@....edu>
To:	linux-ext4@...r.kernel.org
Subject: The jbd_GFP_NORFAIL patch caused the jbd_kmalloc_kzalloc.patch fail


While putting together 2.6.23-rc7-ext4-1 patchset, I noticed that the
jbd_GFP_NOFAIL patch caused a patch conflict with the kmalloc/kzalloc
patch.  I also fixed up the patch comments to make the git log look
prettier. 

						- Ted


    Fix up jbd k[mz]alloc patch so it applies and fix up GFP_NOFAIL comments

diff --git a/jbd_GFP_NOFAIL_flag_cleanup.patch b/jbd_GFP_NOFAIL_flag_cleanup.patch
index 8dec157..da02815 100644
--- a/jbd_GFP_NOFAIL_flag_cleanup.patch
+++ b/jbd_GFP_NOFAIL_flag_cleanup.patch
@@ -1,3 +1,8 @@
+jbd/jbd2: Journal initialization doesn't need __GFP_NOFAIL
+
+Signed-off-by: Mingming Cao <cmm@...ibm.com>
+Signed-off-by: "Theodore Ts'o" <tytso@....edu>
+
 ---
  fs/jbd/journal.c  |    2 +-
  fs/jbd2/journal.c |    2 +-
diff --git a/jbd_kmalloc_kzalloc.patch b/jbd_kmalloc_kzalloc.patch
index a426d0e..8ca0469 100644
--- a/jbd_kmalloc_kzalloc.patch
+++ b/jbd_kmalloc_kzalloc.patch
@@ -22,7 +22,7 @@ Index: linux-2.6.23-rc6/fs/jbd/journal.c
  	journal_t *journal;
  	int err;
  
--	journal = kmalloc(sizeof(*journal), GFP_KERNEL|__GFP_NOFAIL);
+-	journal = kmalloc(sizeof(*journal), GFP_KERNEL);
 +	journal = kzalloc(sizeof(*journal), GFP_KERNEL|__GFP_NOFAIL);
  	if (!journal)
  		goto fail;
@@ -51,7 +51,7 @@ Index: linux-2.6.23-rc6/fs/jbd2/journal.c
  	journal_t *journal;
  	int err;
  
--	journal = kmalloc(sizeof(*journal), GFP_KERNEL|__GFP_NOFAIL);
+-	journal = kmalloc(sizeof(*journal), GFP_KERNEL);
 +	journal = kzalloc(sizeof(*journal), GFP_KERNEL|__GFP_NOFAIL);
  	if (!journal)
  		goto fail;
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html