lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 27 Sep 2007 21:34:14 +0530
From:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	"Theodore Ts'o" <tytso@....edu>
CC:	linux-ext4 <linux-ext4@...r.kernel.org>,
	Alex Tomas <alex@...sterfs.com>,
	Andreas Dilger <adilger@...sterfs.com>
Subject: Re: Review of mballoc-core.patch



Theodore Ts'o wrote:
> Here's an initial code review of the mballoc-core.patch.  As far as I
> can tell, the patch sent by Aneesh doesn't address any of these.
> Aneesh, assuming that you'll be fixing these, could you please combine
> your last set of fixes with fixes to address these, and send out an
> updated mballoc-core.patch?   

Will do that

>Patches on top of patches are useful for
> seeing what has changed, but for the patch queue I'd like to get the
> patches folded into a single patch, since that's what we'd want to have
> placed into the git tree.
> 

That is what i did with my last update. The diff of the source was sent to
the mailing list and and updated mballoc-core.patch was put at www.radian.org
so that we can use the same to update the patch queue. The diff against mballoc.c
helps in reviewing the changes made.


> Thanks!!
> 
> 							- Ted
> 
[.. snip...]
> 
> 
> There are a bunch of FIXME's in this which I assume will get addressed
> before we consider this ready to push to mainline?
> 


I have updated the code with  your suggestion. I haven't resolved all the
questions. The rest are marked with FIXME in the source. The idea is this 
will help Alex to find easily the portion of the code that needs his immediate
attention.

-aneesh
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists