linux-ext4 - Re: [PATCH 1/5] ext4: Code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071015181039.GU8122@schatzie.adilger.int>
Date:	Mon, 15 Oct 2007 12:10:39 -0600
From:	Andreas Dilger <adilger@...sterfs.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/5] ext4: Code cleanup

On Oct 15, 2007  16:25 +0530, Aneesh Kumar K.V wrote:
> -		if (!EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_EXTENTS)) {
> -			err = ext4_journal_get_write_access(handle, EXT4_SB(sb)->s_sbh);
> -			if (err) goto fail;
> -			EXT4_SET_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_EXTENTS);
> -			BUFFER_TRACE(EXT4_SB(sb)->s_sbh, "call ext4_journal_dirty_metadata");
> -			err = ext4_journal_dirty_metadata(handle, EXT4_SB(sb)->s_sbh);
> -		}
> +		err = ext4_update_incompat_feature(handle, sb,
> +						EXT4_FEATURE_INCOMPAT_EXTENTS);
> +		if (err)
> +			goto fail;
> +
> +		BUFFER_TRACE(EXT4_SB(sb)->s_sbh, "call ext4_update_feautre");

You may as well put the BUFFER_TRACE() all into
ext4_update_incompat_feature().

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html