lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071015205344.GA18006@thunk.org>
Date:	Mon, 15 Oct 2007 16:53:44 -0400
From:	Theodore Tso <tytso@....edu>
To:	"Jose R. Santos" <jrs@...ibm.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 01/13][e2fsprogs] Add initial checksum support.

On Thu, Oct 11, 2007 at 02:16:05PM -0500, Jose R. Santos wrote:
> @@ -66,7 +66,9 @@ OBJS= $(DEBUGFS_LIB_OBJS) $(RESIZE_LIB_OBJS) $(E2IMAGE_LIB_OBJS) \
>  	unix_io.o \
>  	unlink.o \
>  	valid_blk.o \
> -	version.o
> +	version.o \
> +	crc16.o \
> +	csum.o

Please keep the order of files in $(OBJS) and $(SRCS) in alphabetical
order.  There are two reasons for this; first of all, it makes it
easier to find files.  Secondly, it makes it less likely for there to
be merge collisions between two patches.  Thanks!!

						- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ