lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 15 Oct 2007 04:43:06 -0500
From:	"Jose R. Santos" <jrs@...ibm.com>
To:	Theodore Tso <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 01/13][e2fsprogs] Add initial checksum support.

On Sun, 14 Oct 2007 22:46:05 -0400
Theodore Tso <tytso@....edu> wrote:

> In crc16.h, this patch assumes that linux/types.h defines uint16_t.  
> 
> There are a couple of problems with this.  
> 
> #1) linux/types.h is non-portable, not only does it not exist on
>  non-Linux systems, apparently on Ubuntu it's not always defining
>  uint16_t.  On my Ubuntu gutsy system, it doesn't always get defined.
> 
>         CC ../../../lib/ext2fs/crc16.c
> In file included from ../../../lib/ext2fs/crc16.c:10:
> ../../../lib/ext2fs/crc16.h:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘const’
> ../../../lib/ext2fs/crc16.h:22: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘crc16’
> 
> 
> The right thing to do is to use ext2fs/ext2_types.h like everything
> else in e2fsprogs, and use __u16 instead of uint16_t.
> 
>      		       	   	 	    - Ted

Yes, I notice the use of linux/types.h as well.  I already have this
fixed on my patch queue and Im in the process of cleaning some of the
other patches as well.

-JRS
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists