| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200710181006.l9IA6vbX006173@imap1.linux-foundation.org> Date: Thu, 18 Oct 2007 03:06:57 -0700 From: akpm@...ux-foundation.org To: torvalds@...ux-foundation.org Cc: akpm@...ux-foundation.org, sandeen@...hat.com, linux-ext4@...r.kernel.org Subject: [patch 129/155] ext3: fix setup_new_group_blocks locking From: Eric Sandeen <sandeen@...hat.com> setup_new_group_blocks() manipulates the group descriptor block bh under the block_bitmap bh's lock. It shouldn't matter since nobody but resize should be touching these blocks, but it's worth fixing up. Signed-off-by: Eric Sandeen <sandeen@...hat.com> C: <linux-ext4@...r.kernel.org> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> --- fs/ext3/resize.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN fs/ext3/resize.c~ext3-fix-setup_new_group_blocks-locking fs/ext3/resize.c --- a/fs/ext3/resize.c~ext3-fix-setup_new_group_blocks-locking +++ a/fs/ext3/resize.c @@ -245,10 +245,10 @@ static int setup_new_group_blocks(struct brelse(gdb); goto exit_bh; } - lock_buffer(bh); - memcpy(gdb->b_data, sbi->s_group_desc[i]->b_data, bh->b_size); + lock_buffer(gdb); + memcpy(gdb->b_data, sbi->s_group_desc[i]->b_data, gdb->b_size); set_buffer_uptodate(gdb); - unlock_buffer(bh); + unlock_buffer(gdb); ext3_journal_dirty_metadata(handle, gdb); ext3_set_bit(bit, bh->b_data); brelse(gdb); _ - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists