linux-ext4 - ext4/balloc.c:read_block_bitmap(): inconsequent NULL checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071019134700.GB3778@stusta.de>
Date:	Fri, 19 Oct 2007 15:47:00 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	sct@...hat.com, akpm@...ux-foundation.org, adilger@...sterfs.com
Cc:	linux-ext4@...r.kernel.org
Subject: ext4/balloc.c:read_block_bitmap(): inconsequent NULL checking

Commit 7c9e69faa28027913ee059c285a5ea8382e24b5d results in the following 
inconsequent NULL checking in fs/ext4/balloc.c:

<--  snip  -->

...
struct buffer_head *
read_block_bitmap(struct super_block *sb, unsigned int block_group)
{
...
        if (!bh)
                ext4_error (sb, __FUNCTION__,
                            "Cannot read block bitmap - "
                            "block_group = %d, block_bitmap = %llu",
                            block_group, bitmap_blk);

        /* check whether block bitmap block number is set */
        if (!block_in_use(bitmap_blk, sb, bh->b_data)) {
...                                       ^^^^^^^^^^

<--  snip  -->

Spotted by the Coverity checker.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html