lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 22 Oct 2007 14:21:09 -0400
From:	Theodore Tso <>
To:	"Jose R. Santos" <>
Subject: Re: [PATCH 10/14] Make e2fsck uninit block group aware.

On Mon, Oct 22, 2007 at 11:02:02AM -0500, Jose R. Santos wrote:
> Hi Ted,
> Aneesh was nice enough to explain how to checkout the next branch.
> This is the only patch that broke so I'm attaching one that applies
> cleanly

Thanks, I was able to clean that up fairly easily myself.  I noticed
though that after applying the patch series, "make check" blew up:

making check in lib/ext2fs
make[1]: Entering directory `/usr/projects/e2fsprogs/e2fsprogs/build/lib/ext2fs'
        CC ../../../lib/ext2fs/tst_bitops.c
        LD tst_bitops
        CC ../../../lib/ext2fs/tst_badblocks.c
        LD tst_badblocks
rw_bitmaps.o: In function `read_bitmaps':
/usr/projects/e2fsprogs/e2fsprogs/build/lib/ext2fs/../../../lib/ext2fs/rw_bitmaps.c:237: undefined reference to `ext2fs_group_desc_csum_verify'
/usr/projects/e2fsprogs/e2fsprogs/build/lib/ext2fs/../../../lib/ext2fs/rw_bitmaps.c:260: undefined reference to `ext2fs_group_desc_csum_verify'
collect2: ld returned 1 exit status
make[1]: *** [tst_badblocks] Error 1
make[1]: Leaving directory `/usr/projects/e2fsprogs/e2fsprogs/build/lib/ext2fs'
make: *** [check-recursive] Error 1

That's a relatively straightforward adjustment to lib/ext2fs/; 
but please do make sure you run "make check" at the end of each patch series.

In fact, something I will normally try to do is make sure that "make
check" runs cleanly after every single patch in a patch series.  That
makes it a lot easier to do git bisect runs.


					- Ted
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists