linux-ext4 - Re: [PATCH] Fix oops with jbd-stats-through-procfs and external journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1193340246.4288.3.camel@localhost.localdomain>
Date:	Thu, 25 Oct 2007 12:24:06 -0700
From:	Mingming Cao <cmm@...ibm.com>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	johann.lombardi@...l.net
Subject: Re: [PATCH] Fix oops with jbd-stats-through-procfs and external
	journal

Thanks, Added to ext4 patch queue at
http://repo.or.cz/w/ext4-patch-queue.git

On Thu, 2007-10-25 at 11:39 -0500, Eric Sandeen wrote:
> When using an external device for the journal,
> jbd2_stats_proc_init() wants to use journal->j_dev in its call
> to bdevname() but it's not assigned yet, resulting in an oops.
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> 
> --- linux.orig/fs/jbd2/journal.c	2007-10-25 11:36:25.772354262 -0500
> +++ linux/fs/jbd2/journal.c	2007-10-25 11:36:35.058278242 -0500
> @@ -1035,11 +1035,11 @@
>  		journal = NULL;
>  		goto out;
>  	}
> -	jbd2_stats_proc_init(journal);
>  	journal->j_dev = bdev;
>  	journal->j_fs_dev = fs_dev;
>  	journal->j_blk_offset = start;
>  	journal->j_maxlen = len;
> +	jbd2_stats_proc_init(journal);
> 
>  	bh = __getblk(journal->j_dev, start, journal->j_blocksize);
>  	J_ASSERT(bh != NULL);
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html