lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <477F0BE8.60307@gmail.com> Date: Sat, 05 Jan 2008 07:47:36 +0300 From: Dmitri Vorobiev <dmitri.vorobiev@...il.com> To: Richard Knutsson <ricknu-0@...dent.ltu.se>, Mathieu Segaud <mathieu.segaud@...ala.cx>, akpm@...ux-foundation.org, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c Andreas Dilger пишет: > On Jan 04, 2008 14:41 +0100, Richard Knutsson wrote: >>> @@ -54,6 +54,6 @@ int __ext4_journal_dirty_metadata(const char *where, >>> { >>> int err = jbd2_journal_dirty_metadata(handle, bh); >>> if (err) >>> - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err); >>> + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err); >>> return err; >>> } >> What about changing the __FUNCTION__ to __func__, while you are at it? > > What's wrong with __FUNCTION__? I thought that was ANSI C? No, it was not. The ANSI C 1990 Standard defines the following so-called "predefined macros": __LINE__, __FILE__, __DATE__, __TIME__, and __STDC__. The ISO/IEC 9899 Standard commonly referred to as the C99, defines a few additional predefined macros, as well as an additional predefined identifier __func__. For more information please refer to the ISO/IEC 9899 document itself, which is freely available for download at the time of me writing this. Although seemingly "natural", the __FUNCTION__ macro has never been part of the C Standard. Dmitri > > Cheers, Andreas > -- > Andreas Dilger > Sr. Staff Engineer, Lustre Group > Sun Microsystems of Canada, Inc. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists