lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080111034240.GA29861@linux-sh.org> Date: Fri, 11 Jan 2008 12:42:40 +0900 From: Paul Mundt <lethal@...ux-sh.org> To: Roel Kluin <12o3l@...cali.nl>, Al Viro <viro@...IV.linux.org.uk>, Mathieu Segaud <mathieu.segaud@...ala.cx>, Richard Knutsson <ricknu-0@...dent.ltu.se>, linux-pcmcia@...ts.infradead.org, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, linux-ext4@...r.kernel.org Subject: Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c On Fri, Jan 11, 2008 at 04:09:45AM +0100, Peter Stuge wrote: > On Thu, Jan 10, 2008 at 10:03:58PM +0100, Roel Kluin wrote: > > -#define DEBUG(x,args...) printk(__FUNCTION__ ": " x,##args) > > +#define DEBUG(x, args...) printk("%s: ", __func__, x, ##args) > > Can this really be expected to work when x contains conversions? > > How about: > > #define DEBUG(x, args...) printk("%s: " x, __func__, ##args) > How about throwing out hand-rolled debug printk wrappers for the brain-damage they are and using the ones the kernel provides instead? dev_dbg() and pr_debug() both manage to get these semantics right, and you can even bury the #define DEBUG underneath some Kconfig silliness if you're the kind of person that leans that way. Maybe we can just amend checkpatch to delete a patch out of protest if it introduces printk() wrappers.. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists