linux-ext4 - Re: [PATCH resend] Fix reading of bitmaps from filesystem image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080114161729.GF4214@duck.suse.cz>
Date:	Mon, 14 Jan 2008 17:17:29 +0100
From:	Jan Kara <jack@...e.cz>
To:	Theodore Tso <tytso@....EDU>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH resend] Fix reading of bitmaps from filesystem image

On Mon 14-01-08 10:57:18, Theodore Tso wrote:
> On Wed, Jan 09, 2008 at 08:54:35PM +0100, Jan Kara wrote:
> > 
> > Reading of bitmaps from image file could never work with more than one
> > group in a filesystem... Fix the loops so that we read appropriate number
> > of blocks.
> 
> OK, so I'm probably being dense, but.... what's the problem?
> 
> You changed the loop from counting in bytes to inodes, but either
> method should work.
  At the beginning of read_bitmap() there is:
        unsigned int block_nbytes = EXT2_BLOCKS_PER_GROUP(fs->super) / 8;
        unsigned inode_nbytes = EXT2_INODES_PER_GROUP(fs->super) / 8;

  Therefore in the loop:
     while (inode_nbytes > 0)

  we end up reading bitmap for just one group...

										Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html