linux-ext4 - Re: [PATCH] Do not try lock_acquire after handle made invalid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080115155914.c72aaea9.akpm@linux-foundation.org>
Date:	Tue, 15 Jan 2008 15:59:14 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jonas Bonn <jonas.bonn@...il.com>
Cc:	sct@...hat.com, linux-ext4@...r.kernel.org, jonas.bonn@...il.com
Subject: Re: [PATCH] Do not try lock_acquire after handle made invalid

On Wed, 16 Jan 2008 00:39:26 +0100
Jonas Bonn <jonas.bonn@...il.com> wrote:

> This likely fixes the oops in __lock_acquire reported as:
> 
> http://www.kerneloops.org/raw.php?rawid=2753&msgid=
> http://www.kerneloops.org/raw.php?rawid=2749&msgid=
> 
> In these reported oopses, start_this_handle is returning -EROFS.
> 
> Signed-off-by: Jonas Bonn <jonas.bonn@...il.com>
> ---
>  fs/jbd/transaction.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
> index 08ff6c7..038ed74 100644
> --- a/fs/jbd/transaction.c
> +++ b/fs/jbd/transaction.c
> @@ -288,10 +288,12 @@ handle_t *journal_start(journal_t *journal, int nblocks)
>  		jbd_free_handle(handle);
>  		current->journal_info = NULL;
>  		handle = ERR_PTR(err);
> +		goto out;
>  	}
>  
>  	lock_acquire(&handle->h_lockdep_map, 0, 0, 0, 2, _THIS_IP_);
>  
> +out:
>  	return handle;
>  }

Yeah, thanks.

It looks like we forgot to port this lockdep support into ext4.  This is
bad.  What else got lost?

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html