linux-ext4 - Re: [PATCH] Convert ext3_ioctl() to an unlocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wsq89foy.fsf@barad-dur.regala.cx>
Date:	Fri, 18 Jan 2008 00:48:29 +0100
From:	Mathieu SEGAUD <mathieu.segaud@...ala.cx>
To:	linux-ext4@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	sct@...hat.com
Subject: Re: [PATCH] Convert ext3_ioctl() to an unlocked_ioctl

Vous m'avez dit récemment :

> --- a/fs/ext3/ioctl.c
> +++ b/fs/ext3/ioctl.c
> @@ -17,12 +17,19 @@
>  #include <linux/smp_lock.h>
>  #include <asm/uaccess.h>
>  
> -int ext3_ioctl (struct inode * inode, struct file * filp, unsigned int cmd,
> +long ext3_ioctl(struct file *filp, unsigned int cmd,
>  		unsigned long arg)
>  {
> -	struct ext3_inode_info *ei = EXT3_I(inode);
> +	struct ext3_inode_info *ei;
> +	struct inode *inode;
>  	unsigned int flags;
>  	unsigned short rsv_window_size;
> +	long retval = 0;
> +
> +	lock_kernel();
> +
> +	inode = filp->f_dentry->d_inode;

I guess this should be
        inode = filp->f_path.dentry->d_inode;


I will repost a fixed patch
sorry for this one.


> +	ei = EXT3_I(inode);
>  
>  	ext3_debug ("cmd = %u, arg = %lu\n", cmd, arg);
>  

-- 
Mathieu
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html