lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20080123140654.fe8c658e.akpm@linux-foundation.org> Date: Wed, 23 Jan 2008 14:06:54 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: "Theodore Ts'o" <tytso@....EDU> Cc: linux-kernel@...r.kernel.org, aneesh.kumar@...ux.vnet.ibm.com, "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org> Subject: Re: [PATCH 24/49] ext4: add block bitmap validation > On Mon, 21 Jan 2008 22:02:03 -0500 "Theodore Ts'o" <tytso@....EDU> wrote: > + if (bh_submit_read(bh) < 0) { > + brelse(bh); > + ext4_error(sb, __FUNCTION__, > "Cannot read block bitmap - " > - "block_group = %lu, block_bitmap = %llu", > - block_group, bitmap_blk); > + "block_group = %d, block_bitmap = %llu", > + (int)block_group, (unsigned long long)bitmap_blk); > + return NULL; > + } > + if (!ext4_valid_block_bitmap(sb, desc, block_group, bh)) { > + brelse(bh); > + return NULL; > + } brelse() should only be used when the bh might be NULL - put_bh() can be used here. Please review all ext4/jbd2 code for this trivial speedup. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists