lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <7vir1i76qj.fsf@gitster.siamese.dyndns.org> Date: Thu, 24 Jan 2008 22:35:16 -0800 From: Junio C Hamano <junio@...ox.com> To: Mathieu Segaud <mathieu.segaud@...ala.cx> cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, sct@...hat.com, Mathieu Segaud <mathieu.segaud@...ala.cx> Subject: Re: [PATCH] Convert ext4_ioctl to an unlocked_ioctl Mathieu Segaud <mathieu.segaud@...ala.cx> writes: > Signed-off-by: Mathieu Segaud <mathieu.segaud@...ala.cx> > --- > fs/ext4/dir.c | 2 +- > fs/ext4/file.c | 2 +- > fs/ext4/ioctl.c | 161 ++++++++++++++++++++++++++++++++--------------- > include/linux/ext4_fs.h | 3 +- > 4 files changed, 112 insertions(+), 56 deletions(-) > > diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c > index f612bef..8f6677a 100644 > --- a/fs/ext4/dir.c > +++ b/fs/ext4/dir.c > @@ -42,7 +42,7 @@ const struct file_operations ext4_dir_operations = { > .llseek = generic_file_llseek, > .read = generic_read_dir, > .readdir = ext4_readdir, /* we take BKL. needed?*/ > - .ioctl = ext4_ioctl, /* BKL held */ > + .unlocked_ioctl = ext4_ioctl, /* BKL held */ Wasn't the purpose of this whole exercise to eventually allow them to be outside BKL? IOW, don't you want to drop this comment for the .unlocked_ioctl member of this struct? - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists