lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <01c801c861ae$c2349990$41a8400a@bsd.tnes.nec.co.jp> Date: Mon, 28 Jan 2008 22:07:38 +0900 From: "Takashi Sato" <t-sato@...jp.nec.com> To: "David Chinner" <dgc@....com> Cc: <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>, <linux-ext4@...r.kernel.org> Subject: Re: [RFC] ext3 freeze feature Hi, Thank you for your comments. > That's inherently unsafe - you can have multiple unfreezes > running in parallel which seriously screws with the bdev semaphore > count that is used to lock the device due to doing multiple up()s > for every down. > > Your timeout thingy guarantee that at some point you will get > multiple up()s occuring due to the timer firing racing with > a thaw ioctl. > > If this interface is to be more widely exported, then it needs > a complete revamp of the bdev is locked while it is frozen so > that there is no chance of a double up() ever occuring on the > bd_mount_sem due to racing thaws..... My patch has the race condition as you said. I will fix it. Cheers, Takashi - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists