[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <87hcgna9f3.fsf@rho.meyering.net>
Date: Tue, 05 Feb 2008 13:13:04 +0100
From: Jim Meyering <jim@...ering.net>
To: linux-ext4@...r.kernel.org
Subject: [PATCH] Handle unusual results from find_tempdir.
An alternative: make find_tempdir set tempdir to default_tempdir
upon malloc failure.
* arch/um/os-Linux/mem.c (make_tempfile): Handle NULL tempdir.
Don't let a long tempdir (e.g., via TMPDIR) provoke heap corruption.
Signed-off-by: Jim Meyering <meyering@...hat.com>
---
arch/um/os-Linux/mem.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/um/os-Linux/mem.c b/arch/um/os-Linux/mem.c
index e114d09..1458385 100644
--- a/arch/um/os-Linux/mem.c
+++ b/arch/um/os-Linux/mem.c
@@ -176,6 +176,9 @@ int __init make_tempfile(const char *template, char **out_tempname,
return -1;
find_tempdir();
+ if (tempdir == NULL || strlen(tempdir) >= MAXPATHLEN)
+ return -1;
+
if (template[0] != '/')
strcpy(tempname, tempdir);
else
--
1.5.4.19.gd3dfd
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists