[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1202434636.3840.25.camel@localhost.localdomain>
Date: Thu, 07 Feb 2008 17:37:16 -0800
From: Mingming Cao <cmm@...ibm.com>
To: Eric Sandeen <sandeen@...hat.com>
Cc: ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] allocate struct ext4_allocation_context from a
kmem cache to save stack space
On Thu, 2008-02-07 at 19:06 -0600, Eric Sandeen wrote:
> Mingming Cao wrote:
>
> > Do you intend to remove the #ifdef CONFIG_PROC_FS, or it's a accident? I
> > think we need keep that to allow ext4 build without procfs configured.
> >
> > Other than this, the patch looks fine to me.:)
>
> oh, it kind of snuck in. It actually should still build, as
> remove_proc_entry is a no-op function w/o the config option.
Oh, I mean the proc_mkdir(EXT4_ROOT, proc_root_fs) will complain w/o
CONFIG_PROC_FS configured.
Mingming
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists