lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1202834708-961-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Date: Tue, 12 Feb 2008 22:15:08 +0530 From: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com> To: tytso@....edu, cmm@...ibm.com Cc: linux-ext4@...r.kernel.org, "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com> Subject: [PATCH] ext4: Set directory link count to zero if we fail to create the directory. With ext4 we fail directory creation if we fail to allocate initial block for the directory. With EXT4_FEATURE_RO_COMPAT_DIR_NLINK, if we fail to create the directory, the inode link count was wrongly set to 1. This cause e2fsck throws the below warning Inode 1015 is a zero-length directory. Clear? yes Inode 1120 is a zero-length directory. Clear? yes Inode 1121 is a zero-length directory. Clear? yes Fix the same by dropping the inode link count using drop_nlink Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com> --- fs/ext4/namei.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index a9347fb..fd3b031 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -1805,7 +1805,7 @@ retry: inode->i_size = EXT4_I(inode)->i_disksize = inode->i_sb->s_blocksize; dir_block = ext4_bread (handle, inode, 0, 1, &err); if (!dir_block) { - ext4_dec_count(handle, inode); /* is this nlink == 0? */ + drop_nlink(inode); ext4_mark_inode_dirty(handle, inode); iput (inode); goto out_stop; -- 1.5.4.1.97.g40aab-dirty - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists