[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080308145351.GB18522@infradead.org>
Date: Sat, 8 Mar 2008 09:53:51 -0500
From: Christoph Hellwig <hch@...radead.org>
To: Duane Griffin <duaneg@...da.com>
Cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
Theodore Tso <tytso@....edu>, sct@...hat.com,
akpm@...ux-foundation.org, adilger@...sterfs.com
Subject: Re: [RFC, PATCH 4/6] jbd: refactor nested journal log recovery
loop into separate functions
On Thu, Mar 06, 2008 at 01:59:12AM +0000, Duane Griffin wrote:
> +static int replay_data_block(
> + journal_t *journal, struct buffer_head *obh, char *data,
> + int flags, unsigned long blocknr)
quite odd formatting, this should be more like:
static int replay_data_block(journal_t *journal, struct buffer_head *obh,
char *data, int flags, unsigned long blocknr)
(same for the other new helpers)
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists