| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 8 Mar 2008 13:45:43 -0500 From: Christoph Hellwig <hch@...radead.org> To: Duane Griffin <duaneg@...da.com> Cc: Christoph Hellwig <hch@...radead.org>, Andreas Dilger <adilger@....com>, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, Theodore Tso <tytso@....edu>, sct@...hat.com, akpm@...ux-foundation.org Subject: Re: [PATCH 2/3] jbd2: replace potentially false assertion with if block On Sat, Mar 08, 2008 at 06:37:08PM +0000, Duane Griffin wrote: > Sorry if I'm missing something here, but I think the caches do need to > be checked. If jbd/ext3 are not modular then even if initialisation > fails the journal code may still be called later. I noticed this when > testing the failure modes after making my original fix. Doh, I think you're right. Just because jbd initialization fails ext3 could succeed later on. We probably want to make ext3 initialization fail early in that case through an exported flag. > I've modified my changes to match the way you suggested doing things > in your earlier reply (and thanks for the review, BTW). If you would > prefer I'll rework my changes as a separate patch on top. Just let me > know. I don't really care how it's delivered. Just consider my patches a scetch and do whatever you think is best with them. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists