linux-ext4 - Re: [PATCH] e2fsprogs- fix ext2fs_swap_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47DAB90C.8050605@redhat.com>
Date:	Fri, 14 Mar 2008 12:42:36 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Theodore Tso <tytso@....edu>
CC:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] e2fsprogs- fix ext2fs_swap_inode_full attr test on BE
 boxes

Theodore Tso wrote:
> On Fri, Feb 29, 2008 at 04:10:21PM -0600, Eric Sandeen wrote:
>> +
>> +	if (hostorder)
>> +		attr_magic = *eaf;
>>  	*eat = ext2fs_swab32(*eaf);
>> +	if (!hostorder)
>> +		attr_magic = *eat;
>> +
>> +	if (attr_magic != EXT2_EXT_ATTR_MAGIC)
>> +		return; /* it seems no magic here */
> 
> The problem with this is that if the magic isn't there, we still end
> up writing 4 bytes into the destination.  So I think this is a better
> patch....
> 

Seems good to me.

Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html