linux-ext4 - Re: [PATCH 1/5] ext4 online defrag header file changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <47DE0F8D.2060106@rs.jp.nec.com>
Date:	Mon, 17 Mar 2008 15:28:29 +0900
From:	Akira Fujita <a-fujita@...jp.nec.com>
To:	Andreas Dilger <adilger@....com>
CC:	cmm@...ibm.com, tytso@....edu, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/5] ext4 online defrag header file changes

Hi Andreas,
>> How about renaming this structure from ext4_extent_data to
>> ext4_extent_info which used the extent in-core structure
>> and put it into ext4_fs_extents.h? 
>> Because in-core super_block is ext4_sb_info.
>>
>> /*
>>  * This is the extent in-core structure.
>>  */
>> struct ext4_extent_info {
>> 	ext4_lblk_t	ee_block;	/* first logical block extent covers */
>> 	int		ee_len;		/* number of blocks covered by extent */
>> 	ext4_fsblk_t	ee_start;	/* first physical block extent covers */
>> };      
>>     
>
> Would it be possible to use the FIEMAP interface to get the file mapping
> data to userspace?  That would avoid the need to have a second ioctl
> with nearly the same data.
>   
Reducing ioctl makes sense.
But EXT4_EXTENTS_INFO needs to get the file mapping data
with inode number not file name.
So we should keep ext4_extents_info structure
or put ino entry in fiemap structure.

Regards, Akira

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html