linux-ext4 - Re: [RFC PATCH] ext4: Update i_diskzie during writepage for delayed allocation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1206137307.3605.29.camel@localhost.localdomain>
Date:	Fri, 21 Mar 2008 15:08:27 -0700
From:	Mingming Cao <cmm@...ibm.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	tytso@....edu, sandeen@...hat.com, Solofo.Ramangalahy@...l.net,
	dmonakhov@...nvz.org, linux-ext4@...r.kernel.org
Subject: Re: [RFC PATCH] ext4:  Update i_diskzie during writepage for
	delayed allocation.

On Fri, 2008-03-21 at 11:48 +0530, Aneesh Kumar K.V wrote:
> We need to update i_disksize after allocating blocks. writepages
> already does this. Update writepage to also  update i_disksize.
> 

I agree that we should update the i_disk size after the allocation, to
avoid possible exposing stale data in case of fs crash happened after
the metadata hit to disk but before data being written out.

> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
> ---
>  fs/ext4/inode.c |   40 +++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 39 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 79930df..50d700f 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -1488,6 +1488,44 @@ out:
> 
>  	return ret;
>  }
> +/* FIXME!! only support data=writeback mode */
> +static int ext4_da_writepage(struct page *page,
> +				struct writeback_control *wbc)
> +{
> +	struct inode *inode = page->mapping->host;
> +	handle_t *handle = NULL;
> +	int ret = 0;
> +	int err;
> +
> +	if (ext4_journal_current_handle())
> +		goto out_fail;
> +
> +	handle = ext4_journal_start(inode, ext4_writepage_trans_blocks(inode));
> +	if (IS_ERR(handle)) {
> +		ret = PTR_ERR(handle);
> +		goto out_fail;
> +	}
> +
> +	if (test_opt(inode->i_sb, NOBH) && ext4_should_writeback_data(inode))
> +		ret = nobh_writepage(page, ext4_get_block, wbc);
> +	else
> +		ret = block_write_full_page(page, ext4_get_block, wbc);
> +
> +	if (!ret && inode->i_size > EXT4_I(inode)->i_disksize) {
> +		EXT4_I(inode)->i_disksize = inode->i_size;
> +		ext4_mark_inode_dirty(handle, inode);
> +	}
> +
> +	err = ext4_journal_stop(handle);
> +	if (!ret)
> +		ret = err;
> +	return ret;
> +
> +out_fail:
> +	redirty_page_for_writepage(wbc, page);
> +	unlock_page(page);
> +	return ret;
> +}
> 
>  static int ext4_da_writepages(struct address_space *mapping,
>  				struct writeback_control *wbc)
> @@ -2015,7 +2053,7 @@ static const struct address_space_operations ext4_journalled_aops = {
>  static const struct address_space_operations ext4_da_aops = {
>  	.readpage	= ext4_readpage,
>  	.readpages	= ext4_readpages,
> -	.writepage	= ext4_writeback_writepage,
> +	.writepage	= ext4_da_writepage,
>  	.writepages	= ext4_da_writepages,
>  	.sync_page	= block_sync_page,
>  	.write_begin	= ext4_da_write_begin,

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html