linux-ext4 - Re: [PATCH 1/5] ext4 online defrag header file changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Mar 2008 19:15:58 +0900
From:	Akira Fujita <a-fujita@...jp.nec.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
CC:	Andreas Dilger <adilger@....com>, cmm@...ibm.com, tytso@....edu,
	linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/5] ext4 online defrag header file changes

Aneesh Kumar K.V wrote:
> On Mon, Mar 24, 2008 at 09:31:03PM +0900, Akira Fujita wrote:
>   
>> Hi Aneesh,
>>     
>>> On Mon, Mar 24, 2008 at 08:00:54PM +0900, Akira Fujita wrote:
>>>       
>>>>>   
>>>>>           
>>>> Is EXT4_IOC_FIEMAP going to be added to the ext4 patch queue?
>>>> I will try to use EXT4_IOC_FIEMAP instead of EXT4_IOC_EXTENTS_INFO
>>>> in ext4 online defrag when kernel supports it.
>>>>         
>>> Can you also look at the sparse warnings with the patches ?
>>>
>>>       
>> I have already released the fixed patch before, but it is not in the ext4 patch queue yet.
>> Mingming, could you replace new ext4-online-defrag-free-space-fragmentation.patch
>> with old one in the ext4 patch queue? 
>>
>>     
>
>   CHECK   fs/ext4/defrag.c
>   fs/ext4/defrag.c:181:7: warning: cast to restricted type
>   fs/ext4/defrag.c:181:7: warning: cast from restricted type
>   fs/ext4/defrag.c:613:21: warning: incorrect type in argument 1
>   (different address spaces)
>   fs/ext4/defrag.c:613:21:    expected void [noderef] <asn:1>*to
>   fs/ext4/defrag.c:613:21:    got struct ext4_group_data_info *<noident>
>   fs/ext4/defrag.c:629:24: warning: incorrect type in argument 1
>   (different address spaces)
>   fs/ext4/defrag.c:629:24:    expected void [noderef] <asn:1>*to
>   fs/ext4/defrag.c:629:24:    got struct ext4_extents_info *<noident>
>   fs/ext4/defrag.c:849:29: warning: potentially expensive pointer
>   subtraction
>   fs/ext4/defrag.c:912:22: warning: potentially expensive pointer
>   subtraction
>
> you would need http://www.kernel.org/pub/software/devel/sparse/
> to find and fix these warnings.
>
>   
Oops, there are a lot of warnings. =-O
Thank you for letting me know.
I will release fixed defrag patches in a few days.

Regards, Akira
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html