linux-ext4 - [PATCH] ext4: Fix filesystem corruption on FS mounted with delalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1207152541.5677.4.camel@ext1.frec.bull.fr>
Date:	Wed, 02 Apr 2008 18:09:01 +0200
From:	Valerie Clement <valerie.clement@...l.net>
To:	linux-ext4 <linux-ext4@...r.kernel.org>
Subject: [PATCH] ext4: Fix filesystem corruption on FS mounted with delalloc

ext4: Fix filesystem corruption on FS mounted with delalloc

From: "Valerie Clement" <valerie.clement@...l.net>

This patch fixes a filesystem corruption issue when the filesystem is
mounted with the delalloc option and blocksize < pagesize.

In the  mpage_put_bnr_to_bhs() function, when skipping the first blocks
at the beginning of the first page, pblock should not be incremented,
otherwise the last blocks are corrupted. When writing into blocks at the
end of a group, the first blocks of the following group can be corrupted.
In that case, we've got the error message below:
EXT4-fs error (device sdc1): ext4_valid_block_bitmap: Invalid block bitmap -
block_group = 6233, block = 51060737 

(Issue found when using fsstress tool on ext4 FS with 1K blocksize)

Signed-off-by: Valerie Clement <valerie.clement@...l.net>

---
 mpage.c |    1 -
 1 file changed, 1 deletion(-)

Index: linux-2.6.25-rc6/fs/mpage.c
===================================================================
--- linux-2.6.25-rc6.orig/fs/mpage.c	2008-04-02 17:12:03.000000000 +0200
+++ linux-2.6.25-rc6/fs/mpage.c	2008-04-02 17:12:11.000000000 +0200
@@ -844,7 +844,6 @@ static void mpage_put_bnr_to_bhs(struct 
 				if (cur_logical >= logical)
 					break;
 				cur_logical++;
-				pblock++;
 			} while ((bh = bh->b_this_page) != head);

 			do {

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html