linux-ext4 - Re: [PATCH][TRIVIAL][e2fsprogs] Rename uninit_groups to uninit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20080410163314.GA5693@webber.adilger.int>
Date:	Thu, 10 Apr 2008 10:33:14 -0600
From:	Andreas Dilger <adilger@....com>
To:	"Jose R. Santos" <jrs@...ibm.com>
Cc:	"Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH][TRIVIAL][e2fsprogs] Rename uninit_groups to uninit_bg.

On Apr 02, 2008  09:03 -0500, Jose R. Santos wrote:
> Rename uninit_groups to uninit_bg.
> 
> <meta_bg> <flex_bg> <uninit_groups> <lazy_bg>
> 
> One of these things is not like the others,
> One of these things just doesn't belong,
> Can you tell which thing is not like the others
> By the time I finish my song?
>        	    by Joe Raposo

Jose,
I don't disagree with this change, but can you please keep compatibility
with the old name for some time, as we have been using the "uninit_groups"
name for some time already.

> diff --git a/lib/e2p/feature.c b/lib/e2p/feature.c
> index cf37447..3fc4f91 100644
> --- a/lib/e2p/feature.c
> +++ b/lib/e2p/feature.c
> @@ -45,7 +45,7 @@ static struct feature feature_list[] = {
>  	{	E2P_FEATURE_RO_INCOMPAT, EXT4_FEATURE_RO_COMPAT_HUGE_FILE,
>  			"huge_file" },
>  	{	E2P_FEATURE_RO_INCOMPAT, EXT4_FEATURE_RO_COMPAT_GDT_CSUM,
> -			"uninit_groups" },
> +			"uninit_bg" },

I think we just need an additional stanza here after this one which has
the old name in it.  That way lookup-by-value will find uninit_bg, and
lookup-by-name will still work.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html