linux-ext4 - Re: [PATCH] check return of ext4_orphan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1207945412.3639.7.camel@localhost.localdomain>
Date:	Fri, 11 Apr 2008 13:23:32 -0700
From:	Mingming Cao <cmm@...ibm.com>
To:	Josef Bacik <jbacik@...hat.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] check return of ext4_orphan_get properly

On Fri, 2008-04-11 at 15:32 -0400, Josef Bacik wrote:
> Hello,
> 
> Hit a panic while running fsfuzzer, seems we are improperly checking the return
> of ext4_orphan_get.  This patch fixes the problem, thank you
> 
> Signed-off-by: Josef Bacik <jbacik@...hat.com>
> 

Thanks, added to the patch queue.
> 
> Index: linux-2.6/fs/ext4/super.c
> ===================================================================
> --- linux-2.6.orig/fs/ext4/super.c
> +++ linux-2.6/fs/ext4/super.c
> @@ -1652,8 +1652,8 @@ static void ext4_orphan_cleanup (struct 
>  	while (es->s_last_orphan) {
>  		struct inode *inode;
> 
> -		if (!(inode =
> -		      ext4_orphan_get(sb, le32_to_cpu(es->s_last_orphan)))) {
> +		inode = ext4_orphan_get(sb, le32_to_cpu(es->s_last_orphan));
> +		if (IS_ERR(inode)) {
>  			es->s_last_orphan = 0;
>  			break;
>  		}
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html