linux-ext4 - [E2FSPROGS, PATCH] Fix "make docs" rule in Makefile for doc folder.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea11fea30804140450l5ee0a0f5o4b18f7fd6e7b6a1d@mail.gmail.com>
Date:	Mon, 14 Apr 2008 17:20:03 +0530
From:	"Manish Katiyar" <mkatiyar@...il.com>
To:	"Theodore Tso" <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org
Subject: [E2FSPROGS, PATCH] Fix "make docs" rule in Makefile for doc folder.

Signed-off-by: Manish Katiyar <mkatiyar@...il.com>

diff --git a/configure.in b/configure.in
index 5243549..e64d817 100644
--- a/configure.in
+++ b/configure.in
@@ -595,6 +595,20 @@ AC_PATH_PROG(LDCONFIG, ldconfig, :)
 AC_CHECK_TOOL(AR, ar, ar)
 AC_CHECK_TOOL(RANLIB, ranlib, :)
 AC_CHECK_TOOL(STRIP, strip, :)
+AC_CHECK_PROG(MAKEINFO, makeinfo, makeinfo, )
+if test "_$MAKEINFO" = "_"; then
+    MAKEINFO="@echo Makeinfo is missing. Info documentation will not
be built.;true"
+else
+    case "$MAKEINFO" in
+      */missing.*)
+        AC_MSG_WARN([
+*** Makeinfo is missing. Info documentation will not be built.])
+        ;;
+      *)
+        ;;
+    esac
+fi
+AC_SUBST(MAKEINFO)
 AC_PROG_INSTALL
 # See if we need a separate native compiler.
 if test $cross_compiling = no; then
diff --git a/doc/Makefile.in b/doc/Makefile.in
index 5494cf0..9c961f3 100644
--- a/doc/Makefile.in
+++ b/doc/Makefile.in
@@ -13,7 +13,7 @@ INSTALL = @INSTALL@

 DVI=texi2dvi
 DVIPS=dvips -o "$@"
-INFO=makeinfo
+INFO=@...EINFO@
 HTML=texi2html

 all:: libext2fs.info libext2fs.dvi







On Mon, Apr 14, 2008 at 2:51 AM, Theodore Tso <tytso@....edu> wrote:
> On Fri, Apr 11, 2008 at 01:25:47AM +0530, Manish Katiyar wrote:
>  > On systems which don't have makeinfo installed by default, "make" or
>  > "make docs" fails with the following error
>  > /home/mkatiyar/e2fs-git> make docs
>  > make[1]: Entering directory `/home/mkatiyar/e2fs-git/doc'
>  >         MAKEINFO libext2fs.info
>  > make[1]: makeinfo: Command not found
>  > make[1]: [libext2fs.info] Error 127 (ignored)
>  >
>  > This patch makes it to bail out with proper error message when
>  > makeinfo is not present.
>
>  Can you send me a Signed-off-by for your patch, per the
>  SUBMITTING-PATCHES file in the e2fsprogs sources?
>
>  Many thanks,
>
>                                          - Ted
>



-- 
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html