linux-ext4 - Re: [PATCH] ext3: Fix typos in messages and comments (journalled -> journaled)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Apr 2008 17:02:53 -0500
From:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, Jan Kara <jack@...e.cz>,
	linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext3: Fix typos in messages and comments (journalled
	-> journaled)


On Wed, 2008-04-30 at 21:27 +0100, Alan Cox wrote:
> On Wed, 30 Apr 2008 10:43:30 -0700
> Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> > On Wed, 30 Apr 2008 17:06:15 +0200
> > Jan Kara <jack@...e.cz> wrote:
> > 
> > > -					"EXT3-fs: Cannot change journalled "
> > > +					"EXT3-fs: Cannot change journaled "
> > 
> > hrm, who said?
> 
> This has come up several times before so I thought it might be time to
> finally dig to the bottom of the pile and end it forever.
> 
> I put on my library hat and went for a dig: the verb is in fact "to
> journalize", which according to the OED means
> 
> "enter (notes or information) in a journal"
> 
> Journal itself is strictly a noun. Thus in English it would be correct
> for a file system to have a journal (from the latin diurnalis if anyone
> cares) but it would appear that it is a journalizing file system.
> 
> The American dictionaries appear to agree with this viewpoint.
> 
> If we regard "journalizing" as incorrect then the natural way to end the
> word would be -lled for British English and -led would certainly sound
> and feel wrong. Indeed the search for the OED turns journalled into
> journal when guessing near words but refuses to consider journaled. Our
> existing policy is not to mess with US v UK v AU v CA v .. spelling
> and that is probably wise. 
> 
> A search of the ACM literature finds "journalized", "journalled" and
> "journaled" are all in use for this operation.

I hate to get into these discussions, but I've used "journaled" a lot,
so I feel I should chime in.

Maybe it's different in the UK, but I've always understood that if the
accent is not on the last syllable, then you do not double the final
vowel: offer, offered.  So if we accept the use of "journal" as a verb,
"journaled" would be correct.  

Since it's not a real word, I'd be happy not to make a big deal out of
it and accept either, so I think we're in agreement.

> I would submit the correct patch is to change the words to journalizing
> and journalized. That would put Linux in agreement with the dictionary,
> avoid US v UK meaning differences and not pose a problem linguistically
> as all forms are currently in use.

That would probably be more correct, but the use of "journal" as a verb
has really gotten ingrained in file system developers brains.  I
personally haven't heard or used "journalized" and it would take some
getting used to.

Shaggy

P.S. Evolution's spell-checker doesn't like "journalize" either, but I
trust that it's correct.
-- 
David Kleikamp
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html