linux-ext4 - Re: [RFC PATCH 8/9][e2fsprogs] Add 64-bit closefs interface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080512150550.GF7029@mit.edu>
Date:	Mon, 12 May 2008 11:05:50 -0400
From:	Theodore Tso <tytso@....edu>
To:	"Jose R. Santos" <jrs@...ibm.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [RFC PATCH 8/9][e2fsprogs] Add 64-bit closefs interface.

On Fri, May 09, 2008 at 11:40:19AM -0500, Jose R. Santos wrote:
> From: Jose R. Santos <jrs@...ibm.com>
> 
> Add 64-bit closefs interface.
> 
> Add new ext2fs_super_and_bgd_loc2() that returns blk64_t pointers.
> The function now returns the number of blocks used by super block and
> group descriptors since with flex_bg, it can no longer be assumed that
> bitmaps and inode tables still resided within the block group.

This change makes me nervous, because (a) I need to assure myself that
ext2fs_super_and_bgd_loc() is going to always do the right thing, and
(b) the changes to the callers of ext2fs_super_and_bgd_loc2() aren't
also described.

So this requires more thought.  One change I would make is to return
the number of blocks via a pointer rather than through a straight
return value.  And also, if I recall correctly, nothing is actually
using the ret_meta_bg pointer, so we might be able to drop that in the
_2 version. of the interface.

We should probably include in this patch series the callers of
ext2fs_super_and_bgd_loc() and assure ourselves that the new interface
actually works correctly and is clean for the users before we finalize
the interface change.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html